Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration for fetch services older than complete_block_timeout #3350

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

rubenvp8510
Copy link
Contributor

@rubenvp8510 rubenvp8510 commented Jan 30, 2024

What this PR does:

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Signed-off-by: Ruben Vargas <ruben.vp8510@gmail.com>
@rubenvp8510
Copy link
Contributor Author

This is ready for review.

@rubenvp8510
Copy link
Contributor Author

Hello @joe-elliott Do you know who can review this? Thank you very much

@@ -73,6 +73,46 @@ func TestSearchUsingJaegerPlugin(t *testing.T) {
callJaegerQuerySearchTraceAssert(t, tempoQuery, "execute", "backend")
}

func TestSearchUsingBackendTagsService(t *testing.T) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice addition!

@joe-elliott joe-elliott merged commit 08d9be8 into grafana:main Feb 2, 2024
14 checks passed
@joe-elliott
Copy link
Member

thx ruben 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants